load balancer: added least request/random/round robin load balancer extension by wbpcode · Pull Request #23472 · envoyproxy/envoy

wbpcode · 2022-10-13T15:32:07Z

Commit Message: load balancer: added least request/random/round robin load balancer extension
Additional Description:

Part of work of #20634. This PR make the least request/random/round robin load balancer as an extension and could be configured by the load_balancing_policy.

One-page simple roadmap doc about the new extensions.
https://docs.google.com/document/d/1GtayHX8orSEChtdn_2stRB8BNY2LE0Y0FatDVGODNHA/edit?usp=sharing

Risk Level: Low. Not change current behavior.
Testing: wait.
Docs Changes: wait.
Release Notes: wait.
Platform Specific Features: wait.

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

repokitteh-read-only · 2022-10-13T15:32:16Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #23472 was opened by wbpcode.

see: more, trace.

wbpcode · 2022-10-13T15:54:30Z

/wait

Waiting for #23474 #23453 to be merged first.

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

…oad-balancer-opt

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode · 2022-10-30T13:18:34Z

cc @markdroth This is the first implementation for the load balancer extension. And it would be very quick to convert the other policies to the extension implementation.

In this implementation, I treat the common_lb_config a shared context of target cluster. Would this be acceptable for you?

…oad-balancer-opt

wbpcode · 2022-11-02T12:00:46Z

Hi, @mattklein123 this is ready for a formal code review 😺

mattklein123

Thanks for working on this. A few questions. Thank you.

/wait

wbpcode · 2023-01-04T01:22:26Z

Question - as part of this (probably in a follow up) would you be willing to have the load balancer code be factory created, so the code for each load balancer can be removed to the respective extension directory and out of the main build, or is that out of scope for you?

It's in my TODO list.

wbpcode · 2023-01-04T01:22:55Z

At a high level makes sense. Can we get integration tests for the new extensions?

Get it.

…oad-balancer-opt

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

alyssawilk · 2023-01-04T16:32:34Z

Awesome! Please cc me on those as I have an annual resolution to avoid more forceRegister problems for E-M and we'll probably need to add some forceRegister there :-P
cc @Augustyniak

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

mattklein123

LGTM, thanks!

wbpcode · 2023-01-06T02:27:38Z

Awesome! Please cc me on those as I have an annual resolution to avoid more forceRegister problems for E-M and we'll probably need to add some forceRegister there :-P cc @Augustyniak

cc @alyssawilk I think I have added some forceRegister in this PR. Could you do a quick check for it? Should I do any change?

alyssawilk · 2023-01-06T19:55:02Z

Sorry I'm theoretically out today so I'm going to ask Rafal to take a look.
Generally when things Envoy uses are moved to extensions we need a PR like this
https://github.com/envoyproxy/envoy/pull/24750/files
to make sure they're not dead code stripped by iOS. I know the DFP uses its own custom host selection, but I don't recall offhand what Lyft uses for the stats cluster so I'll defer to @Augustyniak to make sure we're not losing anything Lyft uses

Augustyniak · 2023-01-06T20:40:00Z

we use round robin so most probably we will need to register factory related to it (in a manner similar to the PR shared by Alyssa https://github.com/envoyproxy/envoy/pull/24750/files). Trying to verify it now in #24797 and will report back.

Augustyniak · 2023-01-06T21:31:19Z

@wbpcode mobile ci jobs in #24797 are green so your changes seems to be working on mobile as-is just fine. I think that something imports/includes round robin in EM already.

In other words, no need to add any explicit factory registration for now.

wbpcode · 2023-01-08T04:01:34Z

Sorry I'm theoretically out today so I'm going to ask Rafal to take a look. Generally when things Envoy uses are moved to extensions we need a PR like this https://github.com/envoyproxy/envoy/pull/24750/files to make sure they're not dead code stripped by iOS. I know the DFP uses its own custom host selection, but I don't recall offhand what Lyft uses for the stats cluster so I'll defer to @Augustyniak to make sure we're not losing anything Lyft uses

I see. This PR doesn't move the implementation of LBs to source/extensions but just make them could be created by the factory.
So, there should no any change to mobile for now. cc @Augustyniak

wbpcode · 2023-01-08T04:02:23Z

/retest

repokitteh-read-only · 2023-01-08T04:02:29Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23472 (comment) was created by @wbpcode.

see: more, trace.

…xtension (envoyproxy#23472) * load balancer: update related methodsfor load balancer extensions Signed-off-by: wbpcode <wangbaiping@corp.netease.com> Signed-off-by: VishalDamgude <vishal.damgude@freshworks.com>

wbpcode added 2 commits October 13, 2022 15:25

load balancer: update related methodsfor load balancer extensions

5b75816

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

load balancer: added least request load balancer extension

d5947bb

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode requested review from alyssawilk, mattklein123 and snowp as code owners October 13, 2022 15:32

repokitteh-read-only Bot added the api label Oct 13, 2022

repokitteh-read-only Bot assigned mattklein123 Oct 13, 2022

wbpcode mentioned this pull request Oct 13, 2022

load balancer: update related methods for load balancer extensions #23474

Merged

repokitteh-read-only Bot added the waiting label Oct 13, 2022

fix build and make it just run

61520ae

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

repokitteh-read-only Bot removed the waiting label Oct 13, 2022

mattklein123 added the waiting label Oct 13, 2022

wbpcode added 2 commits October 29, 2022 09:04

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-l…

51ba30b

…oad-balancer-opt

reverse unnecessary update

fd728ce

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

repokitteh-read-only Bot removed the waiting label Oct 29, 2022

wbpcode added 5 commits October 29, 2022 10:32

add test

89c1582

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

fix docs, release note, format and everything

8f69022

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

revert unexpected deltetion

2c9b321

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

try for coverage

2fc6360

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

update per file coverage

0654452

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode assigned moderation and markdroth and unassigned moderation Oct 30, 2022

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-l…

49e880d

…oad-balancer-opt

mattklein123 requested changes Nov 2, 2022

View reviewed changes

Comment thread source/extensions/extensions_metadata.yaml Outdated

Comment thread source/common/upstream/load_balancer_impl.h

repokitteh-read-only Bot added the waiting label Nov 2, 2022

wbpcode added 3 commits January 4, 2023 06:58

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-l…

5a331b3

…oad-balancer-opt

update change log

6c27a1a

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

more docs

3db7808

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

repokitteh-read-only Bot added waiting and removed waiting labels Jan 4, 2023

add some integration test

bd88fdd

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

repokitteh-read-only Bot removed the waiting label Jan 4, 2023

wbpcode added 2 commits January 5, 2023 02:49

fix test and update assert

82b05d0

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

fix test for ipv6

1e6e1a6

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

mattklein123 approved these changes Jan 5, 2023

View reviewed changes

wbpcode assigned alyssawilk and unassigned RyanTheOptimist Jan 6, 2023

alyssawilk assigned Augustyniak and alyssawilk and unassigned alyssawilk Jan 6, 2023

wbpcode merged commit d036285 into envoyproxy:main Jan 8, 2023

wbpcode mentioned this pull request Jan 12, 2023

load balancer: added maglev/ring hash load balancer extension #24896

Merged

Conversation

wbpcode commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Oct 13, 2022

Uh oh!

wbpcode commented Oct 13, 2022

Uh oh!

wbpcode commented Oct 30, 2022

Uh oh!

wbpcode commented Nov 2, 2022

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wbpcode commented Jan 4, 2023

Uh oh!

wbpcode commented Jan 4, 2023

Uh oh!

alyssawilk commented Jan 4, 2023

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

wbpcode commented Jan 6, 2023

Uh oh!

alyssawilk commented Jan 6, 2023

Uh oh!

Augustyniak commented Jan 6, 2023

Uh oh!

Augustyniak commented Jan 6, 2023

Uh oh!

wbpcode commented Jan 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wbpcode commented Jan 8, 2023

Uh oh!

repokitteh-read-only Bot commented Jan 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wbpcode commented Oct 13, 2022 •

edited

Loading

wbpcode commented Jan 8, 2023 •

edited

Loading